Pass the permalink through the sharing_permalink filter #6353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue #5989. Pass the permalink through the sharing_permalink filter.
samhotchkiss
suggested changes
Feb 10, 2017
| @@ -68,7 +68,7 @@ function sharing_email_send_post_content( $data ) { | |||
| $content = sprintf( __( '%1$s (%2$s) thinks you may be interested in the following post:', 'jetpack' ), $data['name'], $data['source'] ); | |||
| $content .= "\n\n"; | |||
| $content .= $data['post']->post_title."\n"; | |||
| $content .= get_permalink( $data['post']->ID )."\n"; | |||
| $content .= apply_filters( 'sharing_permalink', get_permalink( $data['post']->ID ) ) . "\n"; | |||
There was a problem hiding this comment.
This looks good-- I would change the filter name to jetpack_sharing_permalink, though. Namespacing FTW!
|
Once the change is complete, feel free to mark as "Ready to Merge" |
samhotchkiss
added
[Feature] Sharing
|
There's already a PR for this just awaiting a second review. |
|
Closing this on favor of #6342 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #5989.
Changes proposed in this Pull Request:
Testing instructions:
Add a filter to 'sharing_permalink' similar to this:
function test_sharing_permalink( $url ) {
return add_query_arg( 'key', 'test', $url );
}
add_filter( 'sharing_permalink', 'test_sharing_permalink', 10, 2 );
Load up wp shell
Execute the sharing_email_send_post_content() function similar to this:
return sharing_email_send_post_content( array( 'name' => 'Brian', 'source' => 'brian@automattic.com', 'post' => (object) array( 'ID' => 1178, 'post_title' => 'Markup: HTML Tags and Formatting' ) ) );
You should see ?key=test appended to the end of the permalink.
Proposed changelog entry for your changes: