Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes: #6115 By making sure that $shortcodes_and_callbacks_to_remove exists as an array #6123

Merged
merged 1 commit into from
Jan 19, 2017
Merged

Fixes: #6115 By making sure that $shortcodes_and_callbacks_to_remove exists as an array #6123

merged 1 commit into from
Jan 19, 2017

Conversation

enejb
Copy link
Member

@enejb enejb commented Jan 18, 2017

Fixes: #6115

Testing instructions:

  • Do you still see the php errors?

@enejb enejb added the [Status] Needs Review This PR is ready for review. label Jan 18, 2017
@enejb enejb added this to the 4.5.1 milestone Jan 18, 2017
@enejb enejb self-assigned this Jan 18, 2017
@enejb enejb requested review from gravityrail and pento January 18, 2017 19:11
pento
pento approved these changes Jan 19, 2017
View reviewed changes
Copy link
Contributor

@pento pento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@enejb enejb merged commit 4f49f88 into master Jan 19, 2017
@enejb enejb deleted the fix/6115-remove-php-notices branch January 19, 2017 01:02
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! [Status] Needs Changelog and removed [Status] Needs Review This PR is ready for review. labels Jan 19, 2017
@jeherve jeherve modified the milestones: 4.5.1, 2/17 - February Jan 30, 2017
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pento pento pento approved these changes

@gravityrail gravityrail Awaiting requested review from gravityrail

Assignees

@enejb enejb

Labels
[Package] Sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP notice: Undefined variable: shortcodes_and_callbacks_to_remove
4 participants
@enejb @pento @kraftbj @jeherve