Sync Custom admin menus #5757
Sync Custom admin menus #5757
Conversation
artpi
added
[Package] Sync
[Status] In Progress
[Status] Needs Review
jeherve
added
[Type] Enhancement
| wp_set_current_user( Jetpack_Options::get_option( 'master_user' ) ); | ||
| /** add_menu_page and add_submenu_page hook into admin_menu. Documented in wp-admin/includes/menu.php */ | ||
| do_action( 'admin_menu', '' ); | ||
| /** Lets clean up user switch */ |
There was a problem hiding this comment.
aren't these docblock comments with the double leading *s? also, I thought we preferred // line comments in code to prevent nesting errors with block comments
|
We need to add some test to this. Since the menus only appear on the admin side. I think it should only ever sync this option when we are on the admin side and not though things like cron. Since plugins could be adding the actions and filters only on the admin side and so when we sync this value though cron of the front end the value would not be the same as expected. I also think it is reasonable to assume that we should try to update the menus value when a new plugin is installed. |
| @@ -176,6 +176,26 @@ public static function get_plugins() { | |||
| return apply_filters( 'all_plugins', get_plugins() ); | |||
| } | |||
|
|
|||
| /** | |||
| * Returns items inserted to wp-admin admin page menu by custom plugins and themes. | |||
| * They usually do that bu hooking in admin_menu and calling add_menu_page and add_submenu_page. | |||
eliorivero
added
the
[Status] Needs Author Reply
|
@samhotchkiss : No, it is not worked on at all since I have not coerced anyone to agree on business decision on this. That is my private expectation that once we enable AT we will get a flood of "I installed a plugin and now cant get to it" questions.
Someone has to say "We want this in Jetpack" and I don't want to force stuff in Jetpack that should not be there |
|
Alright, @artpi -- I'm going to go ahead and close for now, let's reopen as we get closer on AT and want/need to flesh out this sort of solution |
Why?
One of the problems with Calypso for Jetpack users is that users not only don't have custom functionality from plugins / themes, but they also don't have any link nor indication about this custom functionality.
This can be especially annoying for AT customers.
Solution
API
WPCOM part of this: D3506-code
Calypso side
Calypso side of this needs some thinking. In the above example submenus for
edit.php?post_type=eventneed to hook into Menu items created by Custom Post Type event, hence pinging @aduth.CC @enej