-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Google Analytics module #5603
Merged
Merged
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
4b59284
Adds Google Analytics support using the wp-google-analytics plugin
3607470
Updates sort order of google analytics plugin
885fad4
Adds pro detection and solves sync issue
498b5f7
Makes form legend translatable.
826da93
Updates module description
b479e5b
Updates module coding style and removes business check function
94b9c1c
PR Feedback
9c31612
Adds Jetpack support link
61dc4d4
Fixes broken tests
339d057
Fixes the Business plan checks and removes unnecessary code
d3c7c05
Adds Google Analytics JS to the js:hint task exception list
ba504ee
Pointing help back to Google Analytics article on WordPress.com
7a59438
Maintains compatibility with WordPress.com option name.
00a5646
Translates the jetpack option name to the WordPress.com name when get…
29faa7b
Makes form placeholder translatable
67c5f6e
Reverts snafu with translatable string on the Verification Tools comp…
17c429c
Updates upgrade button with new Jetpack redirect address
857ade3
Removes unused constant.
e37d1f3
Adds Google Analytics to the PRO list on the search page.
7bc5265
Removes the paywall from the module, adding it to the deactivation list.
a83338a
Adds Google Analytics to the Plans page
0011846
Updates the Google Analytics module heading
fc3597a
Fixes the Google Analytics module appearance when searching
4c9ad80
Removes tokens for custom variables since they are not supported on W…
88d5bed
Removes backward compatibility code since it's not needed with this n…
afb6967
Removed code for logging outgoing links since it's not supported on W…
0bc5782
Adds Jetpack monthly checks to the pro status component
811b199
Removes broken link from the Google Analytics module description
fb7dafe
Removes unused callback functions
8f097d2
Google Analytics code generation function simplified to use only trac…
2bd58f7
Refactors the get options function to retrieve and validate only the …
2a77d8a
Removes whitespace
0b72134
Removes unused variables
650cca5
Changes class name to compy with WordPress coding guidelines
d604658
Removes extra tab
b8546c4
Fixes Google Analytics upgrade url
88b2af4
Removes extra call to isModuleActivated
71bdff6
Removes Google Analytics link from module description
92e236a
Removes the settings form in favor of a link pointing to WordPress.com
41af2a8
Removes upgrade button flash for Google Analytics
921f864
Moves the Google Analytics module to the top with the rest of the pai…
386a85d
Changes the way we import from loadash
ac17e57
Fix undefined && update support link
dereksmart File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
<?php | ||
|
||
/** | ||
* Module Name: Google Analytics | ||
* Module Description: Lets you use Google Analytics to track your WordPress site statistics. | ||
* First Introduced: 4.5 | ||
* Sort Order: 37 | ||
* Requires Connection: Yes | ||
* Auto Activate: No | ||
* Feature: Engagement | ||
* Additional Search Queries: webmaster, google, analytics, console | ||
*/ | ||
|
||
include dirname( __FILE__ ) . "/google-analytics/wp-google-analytics.php"; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense -- can you please update the
isModuleActivated( element[0] )
still used for wordads below?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 88b2af4.