Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS Concatenation: update rules to include new CSS files #5485

Merged
merged 2 commits into from
Nov 8, 2016
Merged

CSS Concatenation: update rules to include new CSS files #5485

merged 2 commits into from
Nov 8, 2016

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Nov 2, 2016

  1. Bring back changes accidentally removed during Merge. 9b81998 undid the changes that were made in f2fd051
  2. Add community widget style to concat styles (see Add My Community widget #3358).

@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended General [Status] Needs Review This PR is ready for review. [Pri] High labels Nov 2, 2016
@jeherve jeherve added this to the 4.4 milestone Nov 2, 2016
@jeherve jeherve changed the title CSS Concatenation issues: update rules to include new CSS files CSS Concatenation: update rules to include new CSS files Nov 2, 2016
@eliorivero eliorivero mentioned this pull request Nov 3, 2016
Merged
@eliorivero eliorivero added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Nov 3, 2016
@eliorivero
Copy link
Contributor

LGTM 🐑
And thanks for adding My Community styles to the concatenation.

@samhotchkiss
Copy link
Contributor

@jeherve -- do you mind rebasing? Once that's done, this looks good to merge

@zinigor zinigor force-pushed the fix/gulp-concatenate branch from 8536bf5 to 9a86ee4 Compare November 8, 2016 08:33
@zinigor zinigor merged commit 025681a into master Nov 8, 2016
@zinigor zinigor deleted the fix/gulp-concatenate branch November 8, 2016 08:54
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
General [Pri] High [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@jeherve @eliorivero @samhotchkiss @kraftbj @zinigor