Admin Page: add the new Apps and Plans landing pages #4345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliorivero
added
[Status] In Progress
Admin Page
eliorivero
force-pushed
the
add/admin-new-landing-pages
branch
from
aebf679 to
d8899dd
Compare
eliorivero
force-pushed
the
add/admin-new-landing-pages
branch
from
04eb8ac to
0c0302d
Compare
… Plans since it's only invisible when user is on Jetpack Free plan
eliorivero
changed the title
eliorivero
added
[Status] Needs Review
eliorivero
force-pushed
the
add/admin-new-landing-pages
branch
from
7c1941e to
4a9f1c6
Compare
…ortCard only when user is in jetpack_premium or jetpack_business plans.
| <div className="jp-jetpack-landing__img-text"> | ||
| <div className="jp-jetpack-landing__column"> | ||
| <h2>{ __( 'Feel the performance' ) }</h2> | ||
| <p>{ __( "All the WordPress apps are built for spped. You'll notice the difference in performance immediately, with near-instant page-loads and less waiting around." ) }</p> |
|
Code-wise looks great except for several nitpicks, well done, thank you! |
zinigor
added
[Status] Ready to Merge
|
Solved issues pointed by @zinigor. |
eliorivero
force-pushed
the
add/admin-new-landing-pages
branch
from
0ba9fb4 to
9fffb70
Compare
…attribute from h2, add extensions to images
eliorivero
removed
the
[Status] Ready to Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4303.
Changes proposed in this Pull Request: