Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON API: Notice when editing sharing buttons via Calypso #4429

Closed
Tracked by #5566
jeherve opened this issue Jul 18, 2016 · 0 comments
Closed
Tracked by #5566

JSON API: Notice when editing sharing buttons via Calypso #4429

jeherve opened this issue Jul 18, 2016 · 0 comments
Labels
[Feature] Sharing Post sharing, sharing buttons [Feature] WPCOM API [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended

Comments

@jeherve
Copy link
Member

jeherve commented Jul 18, 2016

Steps to reproduce the issue

  1. Go to https://wordpress.com/sharing/buttons/
  2. Click on "Edit Sharing buttons"
  3. Move buttons around.
  4. Click on close.
  5. Click on Save changes.
PHP Notice:  Undefined index: visibility in /wp-content/plugins/jetpack/json-endpoints/class.wpcom-json-api-sharing-buttons-endpoint.php on line 140
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Sharing Post sharing, sharing buttons [Feature] WPCOM API [Team] Poseidon labels Jul 18, 2016
@jeherve jeherve modified the milestones: 4.2, 4.2.1 Jul 18, 2016
@jeherve jeherve modified the milestones: 4.2.1, 4.4 Jul 29, 2016
@jeherve jeherve modified the milestones: 4.5, 4.4 Nov 9, 2016
@jeherve jeherve mentioned this issue Nov 9, 2016
Closed
6 tasks
@jeherve jeherve modified the milestones: 4.6, 4.5 Dec 19, 2016
enejb added a commit that referenced this issue Jan 15, 2017
@enejb
Fixes #4429 Remove the PHP Notice
85c94fd 
Check that $is_disabled first before checking that $button has the
attribute visibility.
@enejb enejb mentioned this issue Jan 15, 2017
Merged
@enejb enejb closed this as completed in 26dbd2a Jan 15, 2017
@jeherve jeherve modified the milestones: 4.5.1, 2/17 - February Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Sharing Post sharing, sharing buttons [Feature] WPCOM API [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeherve