Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated functions in Jetpack #4257

Closed
jeherve opened this issue Jun 30, 2016 · 2 comments
Closed

Deprecated functions in Jetpack #4257

jeherve opened this issue Jun 30, 2016 · 2 comments
Labels
General [Type] Good First Bug [Type] Janitorial

Comments

@jeherve
Copy link
Member

jeherve commented Jun 30, 2016

  • like_escape in class.jetpack.php. It's been replaced by wpdb::esc_like()
  • get_theme and get_current_theme in modules/infinite-scroll/infinity.php, modules/theme-tools/inifinite-scroll.php, modules/custom-css/custom-css.php, and modules/module-info.php. We should use wp_get_theme()
  • is_comments_popup() in modules/likes.php
  • screen_icon() in modules/videopress/videopress.php. We should now use get_screen_icon()
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it General [Type] Good First Bug labels Jun 30, 2016
@jeherve jeherve added this to the 4.3 milestone Jun 30, 2016
@kraftbj
Copy link
Contributor

kraftbj commented Jun 30, 2016

$is_comments_popup in likes.php is wrapped in a 4.5 conditional. Once 4.5 is the minimum version (the JP major version after ~August), that whole block can be removed.

@richardmuscat richardmuscat modified the milestones: 4.3, 4.4 Jul 7, 2016
@jeherve jeherve modified the milestones: 4.5, 4.4 Nov 15, 2016
@jeherve jeherve added [Type] Janitorial and removed [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Nov 15, 2016
@jeherve jeherve modified the milestones: Not Currently Planned, 4.5 Jan 12, 2017
briancolinger added a commit that referenced this issue Feb 9, 2017
@briancolinger
Removing the 4.5 conditional block.
d7276db 
Removing the 4.5 conditional block.
Partial fix for #4257.
@briancolinger briancolinger mentioned this issue Feb 9, 2017
Merged
jeherve pushed a commit that referenced this issue Feb 9, 2017
@briancolinger @jeherve
Removing the 4.5 conditional block. (#6337)
11f0b65 
Removing the 4.5 conditional block.
Partial fix for #4257.
@briancolinger
Copy link
Contributor

Closing this issue now because the deprecated functions listed have already been fixed in previous releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
General [Type] Good First Bug [Type] Janitorial
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kraftbj @jeherve @richardmuscat @briancolinger