Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharing: Add label for honeypot #3260

Closed
kraftbj opened this issue Jan 12, 2016 · 2 comments
Closed

Sharing: Add label for honeypot #3260

kraftbj opened this issue Jan 12, 2016 · 2 comments
Assignees
@singerb
Labels
[Feature] Sharing Post sharing, sharing buttons [Focus] Accessibility Improving usability for all users (a11y) [Type] Bug When a feature is broken and / or not performing as intended [Type] Good First Bug

Comments

@kraftbj
Copy link
Contributor

kraftbj commented Jan 12, 2016

The Share by e-mail form includes a spam honeypot, but we do not include a label or other hint for screen readers to indicate the use of the field.

We should add a label with something along the lines of "This field is for validation and should be left unchanged."

Reported in 2484787-t
@kraftbj kraftbj added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Sharing Post sharing, sharing buttons [Type] Good First Bug [Focus] Accessibility Improving usability for all users (a11y) labels Jan 12, 2016
@kraftbj kraftbj added this to the Community milestone Jan 12, 2016
@kraftbj
Copy link
Contributor Author

kraftbj commented Jan 13, 2016

Report from accessibility testing tool:
screen shot 2016-01-13 at 10 05 47

@jeherve
Copy link
Member

jeherve commented Nov 17, 2016

Related: #448

singerb added a commit that referenced this issue Feb 8, 2017
@singerb
Title on the spam honeypot field
8a4675f 
Per accessibility guidelines, this input should have a title or a label
to indicate what it's for. Fixes #3260
@singerb singerb mentioned this issue Feb 8, 2017
Merged
eliorivero pushed a commit that referenced this issue Feb 10, 2017
@singerb @eliorivero
Title on the spam honeypot field
3afd358 
Per accessibility guidelines, this input should have a title or a label
to indicate what it's for. Fixes #3260
samhotchkiss pushed a commit that referenced this issue Feb 10, 2017
@singerb @samhotchkiss
Title on the spam honeypot field (#6332)
98c78e2 
* Title on the spam honeypot field

Per accessibility guidelines, this input should have a title or a label
to indicate what it's for. Fixes #3260

* Make translatable

New text should be translatable, and thus escaped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@singerb singerb

Labels
[Feature] Sharing Post sharing, sharing buttons [Focus] Accessibility Improving usability for all users (a11y) [Type] Bug When a feature is broken and / or not performing as intended [Type] Good First Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kraftbj @jeherve @singerb