Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel: Display additional metadata #295

Closed
kraftbj opened this issue Mar 3, 2014 · 13 comments
Closed

Carousel: Display additional metadata #295

kraftbj opened this issue Mar 3, 2014 · 13 comments
Labels
Cheesy Ticket (Whisky Ticket) - fix this bug, get some whiskey/block of cheese [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Type] Good First Bug

Comments

@kraftbj
Copy link
Contributor

kraftbj commented Mar 3, 2014

Add hooks to allow for the display of additional pieces of metadata for the image (year photograph taken, etc or whatever else).

Originally suggested in 1772224-t.

@jeherve
Copy link
Member

jeherve commented Mar 3, 2014

The jp_carousel_add_data_to_images filter used to do the trick for things like that: see these examples:

Unfortunately, it was removed in 8d654cb. We should probably add it back, not to break other plugins relying on that filter.

In the meantime, maybe jp_carousel_add_data_to_container could do the trick?

@kraftbj
Copy link
Contributor Author

kraftbj commented Mar 3, 2014

jp_carousel_add_data_to_container adds attributes to the opening div of the entire carousel, so it wouldn't be good for metadata for a particular image, nor something that would have a great variety of values, since any action on it would have to target the div's html attrs.

A more robust jp_carousel_add_data_to_images would be great.

@andrewutt
Copy link

Just as a follow up, I ended up hiring someone to help me out with this. He created a small plugin that connected Jetpack with the Advanced Custom Fields plugin. It's very basic, but I'm sure it could be adapted easily into the Jetpack Carousel system. Let me know if you'd like the files and I can send them over.

@kristarella
Copy link

Reinstating that filter would be appreciated.

@jeherve
Copy link
Member

jeherve commented Jan 6, 2015

@jeherve jeherve added this to the 3.4 milestone Jan 7, 2015
@jeherve jeherve modified the milestones: 3.4, 3.5 Jan 28, 2015
@dereksmart dereksmart modified the milestones: 3.6, 3.7 Jun 25, 2015
@samhotchkiss samhotchkiss modified the milestones: 3.7, Needs Triage Aug 28, 2015
@zinigor zinigor modified the milestones: Community, Needs Triage Dec 1, 2015
@paolofid
Copy link

Is there any chance to add geo location information on carousel and link to google maps with pin on the photo geo location?

@lschuyler
Copy link

Also requested in 2497155-t.

@paolofid
Copy link

Thank you to jeherveand and lschuyler
I undertand it is something planned to be added but it's not clear to me if it is something that will happen soon.
You are really making a wonderful work with updates and maintenance of jetpack and carousel.

however it seems that this issue is on hold since long time and this is making me somehow sad... :(

do you have any forecast for that? I think this would make many people so happy! there is no valid alternative around and the way carousel show photos and pieces of exif is simply wonderful!
The further step should be very simple, isn't it?

thank you again, I look forward to receiving your answer

@jeherve
Copy link
Member

jeherve commented Jan 21, 2016

@paolofid We don't have any ETA to add this feature back to Jetpack's Carousel module, but we've discussed some possible ways to add the feature back above. If you'd like, you can contribute to the plugin by proposing a Pull Request adding the options we mentioned above.

@paolofid
Copy link

Hello

What should I do once in the page linked by you? (proposing a pull request)?

I land in https://github.com/Automattic/jetpack/pulls but when I click on “New Pull Request” i go to to a page with forks comparison and I’m not sure what to click.

On a slightly different subject, can I make a donation to have the the feature working again on Jetpack with geo locations and google maps?

@jeherve
Copy link
Member

jeherve commented Jan 25, 2016

What should I do once in the page linked by you? (proposing a pull request)?

If you're not familiar with Pull Requests, you can read more about it here:
https://help.github.com/articles/using-pull-requests/

They're a way for you to propose code changes you wrote to the Jetpack plugin. If you don't feel comfortable editing PHP and JS code, I'm afraid you wont' be able to use that feature.

On a slightly different subject, can I make a donation to have the the feature working again on Jetpack with geo locations and google maps?

That's exactly what this issue is about: bring back the option to add additional metadata like geolocation to the Carousel. We do not, however, accept donations.

@ethansmith
Copy link

+1 for bringing this feature back.

@v18 v18 added the Cheesy Ticket (Whisky Ticket) - fix this bug, get some whiskey/block of cheese label Sep 20, 2016
@eliorivero
Copy link
Contributor

Closing since this is now fixed in #6352. There's one example showing how to add new tags to be displayed and another showing how to rewrite the list including only what you want to display.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cheesy Ticket (Whisky Ticket) - fix this bug, get some whiskey/block of cheese [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Type] Good First Bug
Projects
None yet
Development

No branches or pull requests