Skip to content

Commit

Permalink
Custom CSS: fix a PHP notice (#6154)
Browse files Browse the repository at this point in the history
* Custom CSS: fix a PHP notice

The `$post` parameter for the `_wp_post_revision_fields` filter doesn’t
necessarily have any of the fields set that this function requires.

If they’re not set, bail early.

* Tweak the check for coding standards and readability
  • Loading branch information
pento authored and dereksmart committed Jan 31, 2017
1 parent dedbd07 commit f89fbf1
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions modules/custom-css/custom-css-4.7.php
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,11 @@ public static function customizer_redirect() {
* @return array $fields Modified array to include post_content_filtered.
*/
public static function _wp_post_revision_fields( $fields, $post ) {
// None of the fields in $post are required to be passed in this filter.
if ( ! isset( $post['post_type'], $post['ID'] ) ) {
return $fields;
}

// If we're passed in a revision, go get the main post instead.
if ( 'revision' === $post['post_type'] ) {
$main_post_id = wp_is_post_revision( $post['ID'] );
Expand Down

0 comments on commit f89fbf1

Please sign in to comment.