Skip to content

Commit

Permalink
Widgets - Google Translate: rename global JS function prefixing it to…
Browse files Browse the repository at this point in the history
… avoid conflicts
  • Loading branch information
eliorivero committed Nov 1, 2016
1 parent b58b193 commit a64d6bd
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion modules/widgets/customizer-utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ wp.isJetpackWidgetPlaced = function( placement, widgetName ) {

// Refresh Google Translate
else if ( wp.isJetpackWidgetPlaced( placement, 'google_translate_widget' ) && 'object' === typeof google && google.translate && 'function' === typeof google.translate.TranslateElement ) {
$( 'script[src*="cb=googleTranslateElementInit"]' ).remove().appendTo( $( 'head' ) );
$( 'script[src*="cb=jetpackGoogleTranslateInit"]' ).remove().appendTo( $( 'head' ) );
}

// Refresh Facebook XFBML
Expand Down
2 changes: 1 addition & 1 deletion modules/widgets/google-translate.php
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ function __construct() {
*/
public function enqueue_scripts() {
wp_register_script( 'google-translate-init', plugins_url( 'google-translate/google-translate.js', __FILE__ ) );
wp_enqueue_script( 'google-translate', '//translate.google.com/translate_a/element.js?cb=googleTranslateElementInit', array( 'google-translate-init' ) );
wp_enqueue_script( 'google-translate', '//translate.google.com/translate_a/element.js?cb=jetpackGoogleTranslateInit', array( 'google-translate-init' ) );
wp_localize_script( 'google-translate-init', '_wp_google_translate_widget', array( 'lang' => get_locale() ) );

// Admin bar is also displayed on top of the site which causes google translate bar to hide beneath.
Expand Down
4 changes: 2 additions & 2 deletions modules/widgets/google-translate/google-translate.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/*global google:true*/
/*global _wp_google_translate_widget:true*/
/*exported googleTranslateElementInit*/
function googleTranslateElementInit() {
/*exported jetpackGoogleTranslateInit*/
function jetpackGoogleTranslateInit() {
var langRegex = /[?&#]lang=([a-z]+)/,
langParam = window.location.href.match( langRegex ),
lang = 'object' === typeof _wp_google_translate_widget && 'string' === typeof _wp_google_translate_widget.lang ? _wp_google_translate_widget.lang: 'en';
Expand Down

0 comments on commit a64d6bd

Please sign in to comment.