Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chinese translation. #1167

Closed
wants to merge 1 commit into from
Closed

Add Chinese translation. #1167

wants to merge 1 commit into from

Conversation

malsony
Copy link

@malsony malsony commented Jul 7, 2017

Changes proposed in this Pull Request:

New Chinese translation. With a dramatic funny tone, the translation helps Chinese users understand the use of the theme, and courage them to hack the parent themes.

Related issue(s):

n/a

Todo:

README translation or README_zh-CN.

@davidakennedy
Copy link
Contributor

Hi @malsony! Thanks so much for the pull request, and the work on the translation. 😄

However, this isn't something we would merge. It's in our contribution docs. We decided not to include translations [#50] beyond the existing _s.pot file, a RTL stylesheet [#263], or editor styles [#225], as they are likely to change during development of an _s based theme. _s is meant for custom theme development, and shouldn't be used as a parent theme.

Thanks again, and looking forward to your next contribution!

@grappler
Copy link
Collaborator

grappler commented Jul 8, 2017

@malsony You can always contribute the translations here https://github.com/ptbello/_slated

@malsony
Copy link
Author

malsony commented Jul 16, 2017

@davidakennedy Hi, thanks for the feedback!
@grappler Thanks for your reply! Will review my translation and update, soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants