Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflows: Fix runner image and matrix #946

Merged
merged 3 commits into from
Jul 22, 2023
Merged

Workflows: Fix runner image and matrix #946

merged 3 commits into from
Jul 22, 2023

Conversation

GaryJones
Copy link
Contributor

Description

  • ubuntu-18.04 is no longer supported.
  • moving to a newer runner image means using MySQL 8, which needs a workaround for PHP <=7.3
  • the workaround wasn't working for PHP 7.0 or 5.6, so these have been removed.
  • PHP 8.1 and 8.2 can't be added until PHPUnit version is increased.
  • The new block editor sidebar wasn't appearing before WP 5.7, so don't test before that, with a view to bumping minimum WP (and PHP) version numbers in a future release.

Deploy Notes

None.

Steps to Test

See the passed workflows.

GaryJones and others added 3 commits July 21, 2023 13:50
@GaryJones
Workflows: Use valid runner image
3a6c395 
ubuntu-18.04 is no longer supported.
@GaryJones
Workflows: allow MySQL 8 to run on PHP 7 and below
83cc1db
@GaryJones
CI: Adjust WP and PHP versions in matrix
de781ce 
Can’t expand to newer PHP versions until PHPUnit version has been addressed.
@GaryJones GaryJones added this to the 3.5.11 milestone Jul 22, 2023
@GaryJones GaryJones merged commit 7e31e75 into master Jul 22, 2023
@GaryJones GaryJones deleted the fix/workflow-runner-image branch July 22, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: maintenance
Projects
None yet
Milestone
3.5.11
Development

Successfully merging this pull request may close these issues.
1 participant
@GaryJones