Factorize read render settings code #1978
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
The code to read render settingts was duplicated between translator/reader and common libs, the later being used for the hydra mode of the usd scene format.
In this PR I'm factorizing the code by moving the code from translator/reader/read_options.cpp to common/rendersettings_utils.cpp so that hydra does exactly the same thing as the procedural. This allowed 7 more tests to succeed in hydra mode (tests needing aov shaders, imagers, etc...)
Issues fixed in this pull request
Fixes #1977