Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factorize read render settings code #1978

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

sebastienblor
Copy link
Collaborator

Changes proposed in this pull request
The code to read render settingts was duplicated between translator/reader and common libs, the later being used for the hydra mode of the usd scene format.
In this PR I'm factorizing the code by moving the code from translator/reader/read_options.cpp to common/rendersettings_utils.cpp so that hydra does exactly the same thing as the procedural. This allowed 7 more tests to succeed in hydra mode (tests needing aov shaders, imagers, etc...)

Issues fixed in this pull request
Fixes #1977

@sebastienblor sebastienblor requested a review from cpichard July 13, 2024 11:49
@cpichard
Copy link
Collaborator

cpichard commented Jul 15, 2024

I have the following compilation error on the CI (darwin+linux):

libs/translator/reader/read_options.cpp:52:12: error: no matching function for call to 'ReadRenderSettings'
   52 |     return ReadRenderSettings(renderSettingsPrim, context, context.GetTimeSettings(), context.GetReader()->GetUniverse(), camTargets.empty() ? SdfPath() : camTargets[0]);

@sebastienblor
Copy link
Collaborator Author

After a small change and the compilation issue seems solved in the CI

cpichard
cpichard previously approved these changes Jul 16, 2024
@sebastienblor sebastienblor merged commit f9150ce into Autodesk:master Jul 16, 2024
9 checks passed
@sebastienblor sebastienblor deleted the pr/1977 branch July 16, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hydra test_1321 aov shaders not set properly in hydra
2 participants