Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set proper defaults in the options AA samples and depth #1526

Merged
merged 3 commits into from
May 17, 2023

Conversation

sebastienblor
Copy link
Collaborator

Changes proposed in this pull request
Before reading the render settings prim, we set "default" values in the options, in a way that is consistent with the render delegate.
This will help to get similar results between husk and kick.
Adding test_1525

Issues fixed in this pull request
Fixes #1525

@sebastienblor sebastienblor self-assigned this May 9, 2023
@sebastienblor sebastienblor requested a review from cpichard May 9, 2023 15:07
Copy link
Collaborator

@cpichard cpichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be cool to also have a line in the changelog

@sebastienblor
Copy link
Collaborator Author

would be cool to also have a line in the changelog

added

@cpichard cpichard self-requested a review May 16, 2023 10:33
@sebastienblor sebastienblor merged commit 1225215 into Autodesk:master May 17, 2023
@sebastienblor sebastienblor deleted the pr/1525 branch May 17, 2023 13:54
@sebastienblor sebastienblor mentioned this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set proper defaults when using the usd scene format plugin
2 participants