Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hydra skinned positions cannot have more than 3 keys #1992

Closed
sebastienblor opened this issue Jul 17, 2024 · 1 comment · Fixed by #1993
Closed

Hydra skinned positions cannot have more than 3 keys #1992

sebastienblor opened this issue Jul 17, 2024 · 1 comment · Fixed by #1993
Labels
bug Something isn't working

Comments

@sebastienblor
Copy link
Collaborator

When an object is skinned and we render it through Hydra, we call
HdExtComputationUtils::SampleComputedPrimvarValues with maxSamples = 3 .
If there should be more keys, the returned times are clamped to 3 and we then get only the beginning of the shutter range.
This shows up in test_1443 where the motion length is very different from the expected one. It happens because we only get the first 3 keys out of 7.
@sebastienblor sebastienblor added the bug Something isn't working label Jul 17, 2024
sebastienblor added a commit to sebastienblor/arnold-usd that referenced this issue Jul 17, 2024
@sebastienblor
Allow hydra skinned positions to have more than 3 keys Autodesk#1992
65c94c6
@autodesk-oss-arnold-bot
Copy link

Issue synced internally to ARNOLD-15282

@sebastienblor sebastienblor mentioned this issue Jul 17, 2024
Merged
sebastienblor added a commit that referenced this issue Jul 17, 2024
@sebastienblor
Allow hydra skinned positions to have more than 3 keys (#1993)
30fcb14 
* Allow hydra skinned positions to have more than 3 keys #1992

* Improve changelog
@github-project-automation github-project-automation bot moved this from Todo to Done in Arnold USD Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Arnold USD
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow hydra skinned positions to have more than 3 keys sebastienblor/arnold-usd
1 participant
@sebastienblor