Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base model and implement model class resolution #18

Merged
merged 2 commits into from
Jan 12, 2022

Conversation

cthoyt
Copy link
Contributor

@cthoyt cthoyt commented Jan 12, 2022

Summary

This PR implements a base model for all DDI models where we can keep shared code (it can later be subclassed based on the different tasks or to create meaningful abstractions between models that share concepts). It then uses the class-resolver package for lookup of models, which is how we made the pipeline() function in PyKEEN that I think will go well in this package too.

  • Code passes all tests
  • Unit tests provided for these changes
  • Documentation and docstrings added for these changes

Changes

  • Create base model class
  • Make all models inherit from it
  • Add model resolver

@benedekrozemberczki
Copy link
Contributor

Sorry @cthoyt could you pull again and I will merge!

@benedekrozemberczki benedekrozemberczki merged commit 26284b9 into AstraZeneca:main Jan 12, 2022
@cthoyt cthoyt deleted the model-resolver branch January 12, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants