Spectator - Allow spectator on player or a group only #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3Mydlo3
commented
Aug 14, 2024
veteran29
changed the title
3Mydlo3
commented
Aug 14, 2024
| @@ -42,7 +42,7 @@ | |||
| "LIST", | |||
| [LSTRING(Sides), LSTRING(Sides_Description)], | |||
| [LSTRING(DisplayName), LSTRING(Unconscious)], | |||
| [[0, 1, 2], [LSTRING(Friendly), LSTRING(Own), "str_all_voices"], 0], | |||
| [[0, 1, 3, 4, 2], [LSTRING(Friendly), LSTRING(Own), LSTRING(PlayerGroup), "str_player", "str_all_voices"], 0], | |||
| 1, | |||
There was a problem hiding this comment.
Should Own side remain as the default here? Maybe we should change it?
There was a problem hiding this comment.
I have no opinion on this, can stay as is.
veteran29
requested changes
Aug 14, 2024
Co-authored-by: Filip Maciejewski <veteran29@users.noreply.github.com>
veteran29
reviewed
Aug 14, 2024
veteran29
reviewed
Aug 14, 2024
veteran29
approved these changes
Aug 14, 2024
It does not complain. Given that I've copied those from the game files, I'll proceed with merging without commenting what was commented again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will: