Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tasks - Add default stringtable reference for title and description #186

Merged
merged 9 commits into from
Dec 5, 2021
Merged

Tasks - Add default stringtable reference for title and description #186

merged 9 commits into from
Dec 5, 2021

Conversation

3Mydlo3
Copy link
Member

@3Mydlo3 3Mydlo3 commented Nov 27, 2021 •
edited
Loading

When merged this pull request will:

  • Add default stringtable reference for title STR_Task_<taskConfigName>_Title and description STR_Task_<taskConfigName>_Description. This can remove a lot of boilerplate code when creating tasks.
  • Add ability to specify tag on CfgTasks level or per task. This tag is then used to autogenerate stringtable references STR_<tag>_Task_<taskConfigName>_Title and STR_<tag>_Task_<taskConfigName>_Description.
  • Fix fnc_createTask arguments description.
  • Add tag to example config.
  • Add section to README.

@3Mydlo3 3Mydlo3 added the enhancement Fixes and improvements for existing feature label Nov 27, 2021
@3Mydlo3 3Mydlo3 added this to the ongoing milestone Nov 27, 2021
@3Mydlo3 3Mydlo3 marked this pull request as ready for review December 5, 2021 13:58
@3Mydlo3 3Mydlo3 requested a review from a team as a code owner December 5, 2021 13:58
@3Mydlo3 3Mydlo3 requested review from veteran29 and removed request for a team December 5, 2021 13:58
veteran29
veteran29 approved these changes Dec 5, 2021
View reviewed changes
Copy link
Member

@veteran29 veteran29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@3Mydlo3 3Mydlo3 merged commit f87ebb5 into master Dec 5, 2021
@3Mydlo3 3Mydlo3 deleted the feature/tasks-addDefaultTitleDescription branch December 5, 2021 17:33
@veteran29 veteran29 modified the milestones: ongoing, 1.14.2 Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veteran29 veteran29 veteran29 approved these changes

Assignees
No one assigned
Labels
enhancement Fixes and improvements for existing feature
Projects
None yet
Milestone
1.14.2
Development

Successfully merging this pull request may close these issues.
2 participants
@3Mydlo3 @veteran29