Pr/decode options #725
Merged
Pr/decode options #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunweaver
reviewed
Aug 24, 2018
| *to = '\0'; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Why copy of code here? We should rather use the version found in nxcomp, shouldn't we?
|
I wrote that in the PR comment: I could not manage to make it work.
Besides: the nxagent does not seem to be using any nxcomp function.
…On Fri, Aug 24, 2018 at 11:00 AM, Mike Gabriel ***@***.***> wrote:
@sunweaver commented on this pull request.
This is more a comment / question than a request for changes: Why don't you
simply use the coder version of URLDecodeInPlace from nxcomp straight away?
We need to make URLDecodeInPlace a public symbol and then simply include
NX.h in Args.c.
________________________________
In nx-X11/programs/Xserver/hw/nxagent/Args.c:
> + while (str[0])
+ {
+ if ((str[0] == '%') &&
+ (hexval(str[1]) >= 0) &&
+ (hexval(str[2]) >= 0))
+ {
+ *(to++) = hexval(str[1]) * 16 + hexval(str[2]);
+ str += 3;
+ }
+ else
+ *(to++) = *(str++);
+ }
+ *to = '\0';
+ }
+}
+
Why copy of code here? We should rather use the version found in nxcomp,
shouldn't we?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
new name is more descriptive
Same as in nxcomp's option handling. We really only need it for "," (%2C) and "=" (%3D), currently, but it can handle all encoded characters.
sunweaver
force-pushed
the
pr/decode_options
branch
from
7db35ae to
30a9627
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decode URL encoded characters in options string. This is a much lighter (and cleaner) solution for the problem that #551 tries to solve.
(I did not succeed in linking the URLdecode stuff from nxcomp so I cloned it. If I get that right nxagent is not using anything from nxcomp directly currently.)