DLC Quest Bug Fix more item then location non existing start inventory

[axe-y]

What is this fixing or adding?

fix: Start inventory item would make a miss number of item from the number of location under certain condition

https://discord.com/channels/731205301247803413/1349141593692704829

How was this tested?

Test where run and the world that failed to have the same number of location and item now work properly, other worlds with different item were tested

[Mysteryem]

I don't think this currently works properly if a player adds items to start inventory such that there is more of an item in start inventory than there is of that item in created_items, when there is at least 1 of that item in created_items.

I have given two suggestions that I think would fix the issue.

[Mysteryem]

In general, I think the better design would be to rework item creation to not create excluded items in the first place, rather than removing excluded items after the item pool has been created. Then the count of created items, used to determine how many trap items to add, will be correct from the start and won't have to be adjusted for how many items are going to be removed from the item pool later on at the end of create_items().

Alternatively, only add the trap items after all the excluded items have been removed from the item pool.

The former is better because

        for item in items_to_exclude:
            if item in self.multiworld.itempool:
                self.multiworld.itempool.remove(item)

is not great due to the fact that is has to search the entire multiworld's item pool (twice) for each item.

The effect of this could be minimised to the point where it matters much less, by removing the excluded items from created_items before the items in created_items are added to the multiworld's item pool.

Though I would still recommend not creating items in the first place that you don't actually want to add to the multiworld's item pool.

[axe-y]

I implemented your idea thanks for it