Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: update websockets #4732

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Core: update websockets #4732

wants to merge 2 commits into from
+9 −9

Conversation

Berserker66
Copy link
Member

What is this fixing or adding?

updates websockets

How was this tested?

Just a bit locally
image

@github-actions github-actions bot added affects: core Issues/PRs that touch core and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Mar 11, 2025
@github-actions github-actions bot added the affects: webhost Issues/PRs that touch webhost and may need additional validation. label Mar 11, 2025
@black-sliver
Copy link
Member

black-sliver commented Mar 11, 2025 •
edited
Loading

Closes #4168 when merged.

Code looks good, haven't tested anything yet though.
I think the protocol.extensions check and the idle shutdown needs to be validated. All other changes should be tested by simply connecting.

@black-sliver black-sliver linked an issue Mar 11, 2025 that may be closed by this pull request
Core: make Clients and MultiServer compatible to Websockets 14.x #4168
Open
5 tasks
@ScipioWright ScipioWright added the is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features. label Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
affects: core Issues/PRs that touch core and may need additional validation. affects: webhost Issues/PRs that touch webhost and may need additional validation. is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Core: make Clients and MultiServer compatible to Websockets 14.x
3 participants
@Berserker66 @black-sliver @ScipioWright