Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CV64: Fix some unrandomized locations containing unintended items on specific settings #4728

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

LiquidCat64
Copy link
Contributor

What is this fixing or adding?

Fixes the following locations:

  • Castle Center: Far-left near-side lizard locker: Used to contain a free guaranteed PermaUp if the Permanent Powerups option was enabled and the Lizard Locker Items option was disabled, because I completely forgot about it at the time. Using that combination of settings now replaces it with a Red jewel(L) just like all the other regular unrandomized PowerUps.
  • Clock Tower: Final room entrance slab - Items 1 and 2: This was unwittingly introduced by CV64: Fix the first Waterway 3HB ledge setting the flag of one of the Nitro room item locations. #4277 removing the entire if check for the Multi Hit Breakables option. This particular 3HB is weird because the IDs for the items it drops (normally two 500 GOLDs) are in the exact same address space pointed at by the other 3HB in this room, Renon's final offers slab (normally six 500 GOLDs and two Red jewel (L)s; the first two of the 500 GOLD IDs are shared between them). I normally change the address pointed at by the first 3HB to decouple its items when the 3HB items are randomized, but when that change is applied when the 3HB contents are not changed, the result because of the data that's normally at the newly-pointed address is one of the items is deleted entirely and the other becomes a free guaranteed Garden Key. Whoops!

How was this tested?

Verified the locations had the intended items with and without the specific options combinations.

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Mar 11, 2025
@Exempt-Medic Exempt-Medic added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants