BizhawkClient: port DeathLink handling from SNIClient #4723
+60
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
Exempt-Medic
added
the
is: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Alternative to #4722, this ports the DeathLink handling from SNIClient to BizhawkClient. In prior discussions with Zunawe, we had mentioned potentially porting this to CommonClient. However looking at it closer, it doesn't really make sense to. Maybe the DeathState could be made generic, but the average CommonClient implementation can make use of
on_deathlinkinstead.This also includes porting Mega Man 2 to the new system.
How was this tested?
Generated a game with Mega Man 2 and KDL3, confirmed both games sent and received deathlinks properly.
If this makes graphical changes, please attach screenshots.