Options: Add a column for player ID to --csv_output #4715
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: core
Exempt-Medic
added
the
is: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Adds the player ID int to the .csv file produced when running with --csv_output. Stems from discussion here: https://discord.com/channels/731205301247803413/1347003627180523602
How was this tested?
Created a multiworld with 20 players, half Lingo and half LttP (somewhat arbitrarily). Gave the yaml files random names so the player IDs wouldn't be in game order, and viewed the output to confirm it was still default sorted by game, but contained the player IDs as well.
If this makes graphical changes, please attach screenshots.
It doesn't.