MultiServer: Make it so hint_location doesn't set an automatic priority #4713
+54
−36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative standalone implementation of #4674
I also decided I didn't like how the current code or the code in that PR tied automatic behavior to specific passed statuses. In my opinion, if one specific status is explicitly passed to these functions, that status should be used exactly (except in the case of "found").
As such, there are two scenarios:
2.a This "specific status" happens to be HintStatus.UNSPECIFIED
I think it is cleaner and more elegant to express this as
status: HintStatus | None
, where "None" means "make an automatic status", so that's how I ended up implementing this.Tested:
Lightly