Lingo: Add painting display names #4707
Open
+126
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
Exempt-Medic
added
the
is: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
This PR adds a human-friendly display name for every shuffleable painting in the game. This information can be used by the tracker to help players identify what paintings they are missing or want to go to. This new field is not added to the pickled datafile, and thus this change has no impact on generation whatsoever. However, the datafile did have to be regenerated because the hash of LL1.yaml changed.
Some paintings in crowded rooms were also reordered so that they show up in the tracker in clockwise order.
How was this tested?
Tested that the names displayed correctly with a beta version of the Lingo AP Tracker.
If this makes graphical changes, please attach screenshots.