Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KH2 Doc Update #4609

Merged
merged 2 commits into from
Feb 4, 2025
Merged

KH2 Doc Update #4609

merged 2 commits into from
Feb 4, 2025

Conversation

shananas
Copy link
Contributor

@shananas shananas commented Feb 4, 2025

What is this fixing or adding?

Updating KH2 setup guide for supported mod manager version number

How was this tested?

I read it

Verified

This commit was signed with the committer’s verified signature.
shockey kyle shockey
Mod Manager Version Number
@github-actions github-actions bot added is: documentation Improvements or additions to documentation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Feb 4, 2025
Copy link

@rocket0634 rocket0634 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
This change just reflects an upstream rando change and should help ease confusion.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@ScipioWright ScipioWright added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Feb 4, 2025
@NewSoupVi NewSoupVi added the waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. label Feb 4, 2025
@NewSoupVi
Copy link
Member

@JaredWeakStrike

@NewSoupVi NewSoupVi removed the waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. label Feb 4, 2025
@JaredWeakStrike
Copy link
Collaborator

Lgtm

@NewSoupVi NewSoupVi merged commit db11c62 into ArchipelagoMW:main Feb 4, 2025
10 checks passed
@shananas shananas deleted the KH2-Doc-Update branch February 13, 2025 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: documentation Improvements or additions to documentation. waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants