CC: Expand on make_gui docstring #4449
Merged
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hange without dealing with kivy/kvui directly (there are better places to document those)
github-actions
bot
added
affects: core
beauxq
reviewed
Jan 9, 2025
beauxq
reviewed
Jan 9, 2025
Co-authored-by: Doug Hoskisson <beauxq@users.noreply.github.com>
Co-authored-by: Doug Hoskisson <beauxq@users.noreply.github.com>
ScipioWright
added
the
is: enhancement
nicholassaylor
approved these changes
Jan 23, 2025
qwint
added
waiting-on: core-review
black-sliver
approved these changes
Jan 26, 2025
|
I explicitly only mentioned those two usecases because they can be done without greater kivy knowledge, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
adds docstring to make_gui describing what things you might want to change without dealing with kivy/kvui directly (there are better places to document those)
How was this tested?
eyeballs
If this makes graphical changes, please attach screenshots.