-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TUNIC: Revise ER path hints to be more generous #2847
Conversation
I read the code and it doesn't look bad. I didn't test it however. |
Drafting until I can sit down and add names to the ladder storage entrances |
Alright, it is now ready again. Unique entrance names have been added to the ladder storage entrances, and those identifiers get stripped out when making the entrance hints since they're not helpful there. Also refactored how the ladder storage entrances are made since there was a lot of duplication there. |
I thought of a way to make it a little more efficient, going to work through and check if it works and if it does actually make it more efficient. |
Other method didn't end up being faster, just harder to read. |
Going to have to close this since it not being merged is heavily blocking a much bigger PR for a new feature setting. Going to just combine it into that new one so I don't have to juggle conflicts like a crazy person. |
What is this fixing or adding?
From a recommendation by alwaysintreble, uses all state to generate hint paths to locations in ER. All state appears to have short paths to checks most of the time, so it's decently appropriate to use here.
This also just completely removes the old hinting thing we had going on, and good riddance imo.
How was this tested?
Several gens, hinting everything and looking for anything weird
If this makes graphical changes, please attach screenshots.