Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ocarina of Time: Itemlinks and bugfixes #1157

Merged
merged 24 commits into from
Nov 2, 2022

Conversation

espeon65536
Copy link
Collaborator

What is this fixing or adding?

  • Songs and dungeon items can be used with itemlink with various fill settings. The linked items will only appear in locations that could contain the original items, spread between players. Song locations that don't contain songs will not contain any useful items, if songs were placed there.
  • The trials hint only appears when the number of required trials was not known at the time of generation.
  • Dungeon maps now tell the player if dungeons are MQ or normal if the number was randomized at the time of generation, even if it is 0 or 12.
  • Internal connect name is now randomized to a 16-character string; being able to connect to the incorrect room with a ROM now has probability 1 in 100 nonillion.
  • Shop junk items are now fast-filled, which slightly improves generation time and should fix some rare generation failures.
  • Fixed data bleed when opening a new ROM without properly shutting down the client first.
  • Fixed No Logic failing to roll with entrance randomizer.
  • Fixed Deku Shield potentially not being purchasable in closed forest with interior entrances randomized.
  • Fixed the remaining locations not sending immediately upon pickup in game.
  • Fixed crash when placing songs or dungeon items as nonlocal when they were forced local by settings. The local items are now favored, in accordance with AP's general treatment of such conflicts.
  • Fixed barren hint oversight that would cause some regions with useful items to be incorrectly marked as barren.
  • Fixed Gerudo Membership Card location appearing as checked with open fortress.

Include dungeon rewards in itempool to allow for ER improvement
Better validate_world function by checking for multi-entrance incompatibility more efficiently
Fix some generation failures by ensuring all entrances placed with logic
Introduce bias to some interior entrance placement to improve generation rate
in particular, no longer assumes that exactly the number of vanilla keys is present, which lets it place more or fewer items.
Now should autosend cows, DMT/DMC great fairies, medigoron, and bombchu salesman
This should be every check autosending. these ones are super weird for some reason and didn't get fixed with the others
…d forest

hence Deku Shield can be bought to leave the forest
Connect name is now a random 16-character string.
This should prevent any issues with connecting to a room with the wrong ROM with probability almost 1.
…icted placements according to player settings
set and list builtins don't have proper typing support until 3.9, apparently
… open and card not randomized

another long-standing bug squished
…me connections

I don't understand why people keep doing this
it was a real error though
@black-sliver black-sliver added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Oct 31, 2022
from Options import Option, DefaultOnToggle, Toggle, Range, OptionList, DeathLink
from .LogicTricks import normalized_name_tricks
from .ColorSFXOptions import *


class TrackRandomRange(Range):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit sad to see this be OoT specific. I think Violet wanted something similar for Witness.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't think of a good way to make this work for all option types besides overhauling Generate.py, and I'd rather do that in a separate PR. If that happens, this randomization tracking will be extended to all options that support weighting.

@Berserker66 Berserker66 merged commit a6e1e14 into ArchipelagoMW:main Nov 2, 2022
@espeon65536 espeon65536 deleted the oot_updates branch January 26, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants