-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ocarina of Time: Itemlinks and bugfixes #1157
Conversation
Include dungeon rewards in itempool to allow for ER improvement Better validate_world function by checking for multi-entrance incompatibility more efficiently Fix some generation failures by ensuring all entrances placed with logic Introduce bias to some interior entrance placement to improve generation rate
in particular, no longer assumes that exactly the number of vanilla keys is present, which lets it place more or fewer items.
Now should autosend cows, DMT/DMC great fairies, medigoron, and bombchu salesman This should be every check autosending. these ones are super weird for some reason and didn't get fixed with the others
…d forest hence Deku Shield can be bought to leave the forest
Connect name is now a random 16-character string. This should prevent any issues with connecting to a room with the wrong ROM with probability almost 1.
…icted placements according to player settings
set and list builtins don't have proper typing support until 3.9, apparently
…nto oot_updates
…nto oot_updates
… open and card not randomized another long-standing bug squished
…me connections I don't understand why people keep doing this
it was a real error though
from Options import Option, DefaultOnToggle, Toggle, Range, OptionList, DeathLink | ||
from .LogicTricks import normalized_name_tricks | ||
from .ColorSFXOptions import * | ||
|
||
|
||
class TrackRandomRange(Range): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit sad to see this be OoT specific. I think Violet wanted something similar for Witness.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't think of a good way to make this work for all option types besides overhauling Generate.py, and I'd rather do that in a separate PR. If that happens, this randomization tracking will be extended to all options that support weighting.
What is this fixing or adding?