Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: make Clients and MultiServer compatible to Websockets 14.x #4168

Closed
5 tasks
black-sliver opened this issue Nov 10, 2024 · 1 comment · Fixed by #4732
Closed
5 tasks

Core: make Clients and MultiServer compatible to Websockets 14.x #4168

black-sliver opened this issue Nov 10, 2024 · 1 comment · Fixed by #4732
Assignees

Comments

@black-sliver
Copy link
Member

black-sliver commented Nov 10, 2024

What task needs to be completed?

14.x changed the async implementation and has a different API.

In the transition period, we can either use the new implementation on 13.x (not sure how to enable it though), or make non-ported parts explicitly use the legacy implementation that is still available in 14.0.
See 14.0 Changelog and 14.0 Upgrade Guide.

There is no pressure to do it just now since 0.5.1 will stick with Websockets 13.x and there are no known issues with it, but since we'll drop py 3.8 with 0.6.0, it'd be nice to get it done for 0.6.0, hence the Milestone.

  • Make MultiServer compatible (either new API or explicit legacy)
  • Make MultiServer use the new API/implementation
  • Make CommonClient compatible (either new API or explicit legacy)
  • Make CommonClient use the new API/implementation
  • Check / list other components here
@black-sliver
Copy link
Member Author

zerks volunteered

@black-sliver black-sliver linked a pull request Mar 11, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants