fix: transaction signing issues [APE-1254] #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APE-1254 "fix: everything" (ApeWorX/ape-ledger #39)
What I didWIP How I did itHow to verify itChecklist
ApeWorX/ape-ledger #39 by antazoey on GitHub via LinearSync |
antazoey
changed the title
fubuloubu
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fixes: issue where transaction signing would exit before waiting for sing
fixes: issue where transaction serialization would fail because of weird objects
refactor: use ledger-eth lib, delete code
fix: cli would show wrong number of accounts
made progress but more to come, goodnight, really tired
How I did it
How to verify it
Checklist