Give Drill type drawers #10524
Open
Give Drill type drawers #10524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you show the difference side by side? |
|
No visual differences just more mod customization |
alr, so i don't see anything wrong here |
|
No legacy drawRim support. Will cause issues with every mod using rims. |
|
As I said in the discord I'm looking for ways |
|
just make DrawRim do nothing if no rim sprite is found |
Anuken
requested changes
Apr 4, 2025
| //does nothing for most Drills, as those do not require items. | ||
| if((consTimer += delta()) >= consumeTime){ | ||
| consume(); | ||
| consTimer %= 1f; |
|
|
||
| return (drillProgress + consumeProgress) / 2f; |
There was a problem hiding this comment.
Why is consumeProgress even a factor here? It has nothing to do with progress until the next item. Why is it averaged?
|
|
||
| return (drillProgress + consumeProgress) / 2f; | ||
| } | ||
| @Override |
|
Fixing issues later today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If your pull request is not translation or serverlist-related, read the list of requirements below and check each box:
Gives drawers to drills whilst preserving most base drill stuffs.