Update feed URL when redirected #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
fixes #1393 |
TomHennen
added a commit
that referenced
this pull request
Nov 27, 2015
Update feed URL when redirected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frankly, inceptor is not the only solution, but the easiest.
Another would be the HttpDownloader, but it gets far more complicated. We would have to check prior requests, if one of those was redirected. Then, the DownloadRequest source (download url) would have to be non-final. Next, we would have to check any code that used the DownloadRequest if it assumes the source field to be final and so on (e.g. when removing the requests from the current downloads).
I think it is easier to update the field when we encounter a redirect. I don't think there is any other reason for a feed URL to change, so we actually don't need to update a saved feed's URL when refreshing the same.