Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix regex in nbdev.doclinks._nbpath2html #1218

Merged
merged 1 commit into from
Nov 9, 2022
Merged

fix regex in nbdev.doclinks._nbpath2html #1218

merged 1 commit into from
Nov 9, 2022

Conversation

seeM
Copy link
Contributor

@seeM seeM commented Nov 9, 2022

addresses #1210 (comment):

afaict this is not the correct fix. The * seemed fine, for single digit prefixes. I think it just needs to be modified to only match the start of the name

fixes #1210

@seeM seeM requested review from jph00 and hamelsmu November 9, 2022 07:36
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@jph00 jph00 merged commit effa1ee into AnswerDotAI:master Nov 9, 2022
@seeM seeM mentioned this pull request Nov 12, 2022
Closed
@seeM seeM deleted the fix-1210 branch December 5, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jph00 jph00 Awaiting requested review from jph00

@hamelsmu hamelsmu Awaiting requested review from hamelsmu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seeM @jph00