Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nbdev_install_quarto may install and remove unrelated packages #1208

Merged
merged 1 commit into from
Nov 8, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions nbdev/quarto.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@ def _sprun(cmd):

def _install_linux():
system(f'curl -LO {BASE_QUARTO_URL}quarto-linux-amd64.deb')
system('sudo dpkg -i *64.deb && rm *64.deb')
system('sudo dpkg -i quarto-linux-amd64.deb && rm quarto-linux-amd64.deb')

def _install_mac():
system(f'curl -LO {BASE_QUARTO_URL}quarto-macos.pkg')
system('sudo installer -pkg quarto-macos.pkg -target /')
system('sudo installer -pkg quarto-macos.pkg -target / && rm quarto-macos.pkg')

@call_parse
def install_quarto():
Expand Down
4 changes: 2 additions & 2 deletions nbs/api/quarto.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,11 @@
"\n",
"def _install_linux():\n",
" system(f'curl -LO {BASE_QUARTO_URL}quarto-linux-amd64.deb')\n",
" system('sudo dpkg -i *64.deb && rm *64.deb')\n",
" system('sudo dpkg -i quarto-linux-amd64.deb && rm quarto-linux-amd64.deb')\n",
" \n",
"def _install_mac():\n",
" system(f'curl -LO {BASE_QUARTO_URL}quarto-macos.pkg')\n",
" system('sudo installer -pkg quarto-macos.pkg -target /')\n",
" system('sudo installer -pkg quarto-macos.pkg -target / && rm quarto-macos.pkg')\n",
"\n",
"@call_parse\n",
"def install_quarto():\n",
Expand Down