Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update All Python Scripts to nbs similar to nbdev_update_lib in v1 #769

Closed
BirkhoffG opened this issue Aug 6, 2022 · 2 comments · Fixed by #947
Closed

Update All Python Scripts to nbs similar to nbdev_update_lib in v1 #769

BirkhoffG opened this issue Aug 6, 2022 · 2 comments · Fixed by #947
Assignees
Labels
bug Something isn't working
Milestone

Comments

@BirkhoffG
Copy link

I am wondering why nbdev_update in v2 works differently in v1. In v1, nbdev_update_lib will update all modified python scripts, which is very handy.

However, in v2, to update changes made in the python module, we need to

  1. cd python_module
  2. nbdev_update python_file.py

This is a cumbersome process. Why not just keep the v1 design by just typing the nbdev_update in the parent directory?

@BirkhoffG
Copy link
Author

Also, the document is not very clear in v2.

If you are in the parent directory, then nbdev_update python_module/file.py will not work if your notebooks are in the directory (e.g., in nbs directory). You need to move to the python module first, and update the module.

I don't know if this is intended or just a bug. Anyway, I cannot find clear documentation on nbdev_update, so it would be great if you could document this.

@jph00
Copy link
Contributor

jph00 commented Aug 6, 2022

I don't know if this is intended or just a bug.

It's a bug!

@jph00 jph00 added the bug Something isn't working label Aug 6, 2022
@hamelsmu hamelsmu self-assigned this Aug 26, 2022
@jph00 jph00 added this to the v.next milestone Aug 26, 2022
hamelsmu added a commit that referenced this issue Aug 27, 2022
@hamelsmu hamelsmu mentioned this issue Aug 27, 2022
hamelsmu added a commit that referenced this issue Aug 27, 2022
@hamelsmu hamelsmu mentioned this issue Aug 27, 2022
jph00 added a commit that referenced this issue Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants