Merge pull request #1208 from seeM/fix-1182

fix: `nbdev_install_quarto` may install and remove unrelated packages
AnswerDotAI · Nov 8, 2022 · 12d09dd · 12d09dd
2 parents f0fb8d2 + 2c86cbe
commit 12d09dd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/nbdev/quarto.py b/nbdev/quarto.py
@@ -30,11 +30,11 @@ def _sprun(cmd):
 
 def _install_linux():
     system(f'curl -LO {BASE_QUARTO_URL}quarto-linux-amd64.deb')
-    system('sudo dpkg -i *64.deb && rm *64.deb')
+    system('sudo dpkg -i quarto-linux-amd64.deb && rm quarto-linux-amd64.deb')
 
 def _install_mac():
     system(f'curl -LO {BASE_QUARTO_URL}quarto-macos.pkg')
-    system('sudo installer -pkg quarto-macos.pkg -target /')
+    system('sudo installer -pkg quarto-macos.pkg -target / && rm quarto-macos.pkg')
 
 @call_parse
 def install_quarto():

diff --git a/nbs/api/quarto.ipynb b/nbs/api/quarto.ipynb
@@ -89,11 +89,11 @@
     "\n",
     "def _install_linux():\n",
     "    system(f'curl -LO {BASE_QUARTO_URL}quarto-linux-amd64.deb')\n",
-    "    system('sudo dpkg -i *64.deb && rm *64.deb')\n",
+    "    system('sudo dpkg -i quarto-linux-amd64.deb && rm quarto-linux-amd64.deb')\n",
     "    \n",
     "def _install_mac():\n",
     "    system(f'curl -LO {BASE_QUARTO_URL}quarto-macos.pkg')\n",
-    "    system('sudo installer -pkg quarto-macos.pkg -target /')\n",
+    "    system('sudo installer -pkg quarto-macos.pkg -target / && rm quarto-macos.pkg')\n",
     "\n",
     "@call_parse\n",
     "def install_quarto():\n",