Skip to content

Commit

Permalink
Fix plotly#2
Browse files Browse the repository at this point in the history
  • Loading branch information
AnnMarieW committed Jun 9, 2022
1 parent 67d1bec commit 5676665
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ This project adheres to [Semantic Versioning](https://semver.org/).
## Unreleased

### Fixed

- [#2087](https://github.com/plotly/dash/pull/2087) Fix bug [#2086](https://github.com/plotly/dash/issues/2086) in which using id as a key within a component's id breaks the new callback context's args_grouping function.
- [#2084](https://github.com/plotly/dash/pull/2084) In dash 2.5.0, a default viewport meta tag was added as recommended for mobile-optimized sites by [mdn](https://developer.mozilla.org/en-US/docs/Web/HTML/Viewport_meta_tag)
This feature can be disabled by providing an empty viewport meta tag. e.g. `app = Dash(meta_tags=[{"name": "viewport"}])`

Expand Down
2 changes: 1 addition & 1 deletion dash/_callback_context.py
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ def display(btn1, btn2):
grouping = getattr(flask.g, "args_grouping", {})

def update_args_grouping(g):
if isinstance(g, dict) and isinstance(g.get("id"), dict):
if isinstance(g, dict) and "id" in g and "property" in g:
str_id = stringify_id(g["id"])
prop_id = f"{str_id}.{g['property']}"

Expand Down

0 comments on commit 5676665

Please sign in to comment.