👨🏭 Special character fix #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't it possible to let the decode part to iTunes-bridge itself instead of leaving it to the user? I will investigate this in the next days when I'll have time, but otherwise thank you for the contribution! |
|
I moved the decodeURI part to the part where iTunes-bridge gets the result from the shell so it avoids decoding each value in the user code etc. Tested it on a Windows 7 VM but cmd always shows ?????? when you input special characters to it, and I didn't have time to test it with an app using the package. Tell me if it works for you, and if it does I'll merge the fix! |
|
|
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #9