-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opshin Language Analysis Report #1
Open
SuganyaAK
wants to merge
22
commits into
main
Choose a base branch
from
mileston2-progress
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpetruska
reviewed
Dec 16, 2024
The two lambda functions with parameter names `i_1` and `i_2` correspond to the variables named `n` and `validator`, respectively. These variables, however, are not being used. This behavior is expected by the OpShin code, which assumes that it will always be able to access these variables without generating invalid UPLC." | ||
The two lambda functions with parameter names `n_1` and `validator_0` correspond to the variables named `n` and `validator`, respectively. | ||
These variables, however, are not being used. | ||
This behavior is expected by the OpShin code, which assumes that it will always be able to access these variables without generating invalid UPLC. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
Also, this has the effect that script sizes are usually bigger then strictly necessary, since dead code elimination is not implemented by the OpShin optimizer. | |
…earch for vulnerabilities, as nested bullet points in the `Topics to cover` section of audit-tracker-template.typ - Added an (incomplete) Limitations and Deviations sections to the Introduction in milestone2_langanalysis.md - Added a Compilation pipeline subsection to Compilation and Execution, because an enumeration of the pipeline steps is useful to be able to reference. - Expanded on Finding 03 - Added Findings 06 to 19
- some minor corrections
- pdf documents made consistent with .md and .typ content
Findings 6 to 18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.