(Chore) Improve tsconfig #1830
Merged
(Chore) Improve tsconfig #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes sure that only TS files are included in the list of files to parse by the compiler
This was referenced Nov 2, 2021
Closed
Closed
Merged
janjaap
pushed a commit
that referenced
this pull request
Nov 3, 2021
* Prevent breaking app when browser (cookie/local/session) storage is disabled * Prevent error when incident location is null * Adds array flatMap polyfill * Improves incident-list type * Change core-js polyfill to local polyfill * Notify userwhen login fails * (Chore) Empty ref fix * (Chore) AbortController sub * [SIG-4035] Convert categories model to TS * Converts category model selectors to TS * Fixes tests * Corrects mock implementation for incident detail * Changes type * Corrects type errors * Removes debugger statement * Fixes another round of types * Adds App mode ADR * (Chore) cleanup same-area spec * Removes flakiness from test; disables unreliable e2e test * Removes commented line * Fixes incident type to prevent type errors * Removes faker package * [SIG-3824] End status styling * Adds global css class for incident status styling * Fixes type error * Fixes test * Creates separate Status component * Removes outdated test cases * - adds data-testid attributes to elements for better QA targeting - removes style-specific integration tests; not the responsibility of the e2e-tests * Adds api url where msw request handler is used * Fixes unit test errors * (Chore) Improve tsconfig (#1830) Makes sure that only TS files are included in the list of files to parse by the compiler * [SIG-3281] Show number of chars for textarea (#1829) * Adds separate AddNote components Corrects types Moves components to different scope * Fixes types for register ref * Corrects Select prop type * Adds complete coverage for AddNote component * Adds SelectLoader component * Prefers defaultValue over value when instantiating TextArea component * Allows for configurable field name in getError for note. * Deletes temp files * Replaces register prop with onChange handler * Replaces register prop with onChange handler for IncidentSplitRadioInput component * Refactors addNote error function so that it is no longer a higher order function * Renders IncidentSplitFormIncident tests in context provider * Makes sure incident detail AddNote component calls error function correctly * Upgrades react-hook-form to latest stable * Adjusts IncidentReplyContainer components to work with the new version of react-hook-form * Removes generic AddNote component to top level components folder * Converts StatusForm related imports to TS and corrects types accordingly * Corrects types for Status and context * Increases default test timeout because of slow tests in FilterForm * Removes memo from internal FilterForm components * Makes sure value updates are reflected by the textarea element * Uses form context provider for incident split form * Corrects condition in category selectors * Ensures correct types for IncidentDetail components * Ensures correct type usage * Moves default texts styled components into their own file * Removes empty test case * Corrects Coordinates type * Ensures cleanup after each test case for useFetchReporter hook * Removes unused file * (Chore) Improve page rendering speed (#1831) * (Chore) Improve page rendering speed Sets the `contain` CSS property on several elements to improve the in-page rendering. See https://css-tricks.com/almanac/properties/c/contain/ for reference. * Adds one more contain rule * Update PDOK WMTS service endpoint (#1832) * [FE#92] Asset selector (#1820) * Copy container selector * Make the asset select usable * Make the language configurable * Make the wfs endpoint more flexible * Remove obsolete context * Add fallback icon config * Update unit tests * Use single curly brace in endpoint * Remove memo * Fix typing * Sync/master develop (#1838) * Release/v1.63.0 (#1828) * Prevent breaking app when browser (cookie/local/session) storage is disabled * Prevent error when incident location is null * Adds array flatMap polyfill * Improves incident-list type * Change core-js polyfill to local polyfill * Notify userwhen login fails * (Chore) Empty ref fix * (Chore) AbortController sub * [SIG-4035] Convert categories model to TS * Converts category model selectors to TS * Fixes tests * Corrects mock implementation for incident detail * Changes type * Corrects type errors * Removes debugger statement * Fixes another round of types * Adds App mode ADR * (Chore) cleanup same-area spec * Removes flakiness from test; disables unreliable e2e test * Removes commented line * Fixes incident type to prevent type errors * Removes faker package * [SIG-3824] End status styling * Adds global css class for incident status styling * Fixes type error * Fixes test * Creates separate Status component * Removes outdated test cases * - adds data-testid attributes to elements for better QA targeting - removes style-specific integration tests; not the responsibility of the e2e-tests * Adds api url where msw request handler is used * Fixes unit test errors Co-authored-by: Maurits Ridder <maurits.ridder@amsterdam.nl> Co-authored-by: Maurits <10672773+MauritsR@users.noreply.github.com> * Update PDOK WMTS service endpoint (#1832) * Reverts conversion to object * Increments node version * Reverts packages update Co-authored-by: Maurits <10672773+MauritsR@users.noreply.github.com> Co-authored-by: Maurits Ridder <maurits.ridder@amsterdam.nl> Co-authored-by: Boris Arkenaar <boris@arkenaar.com> * Reverts package lock changes Co-authored-by: Maurits Ridder <maurits.ridder@amsterdam.nl> Co-authored-by: Maurits <10672773+MauritsR@users.noreply.github.com> Co-authored-by: Boris Arkenaar <boris@arkenaar.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes sure that only TS files are included in the list of files to parse by the compiler