-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Update hyphenation tokens #1914
Conversation
c7d73af
to
435c054
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Also, text-wrap: pretty
is something to consider, it will prevent multiple lines that end in hyphens (which is ugly): https://developer.chrome.com/blog/css-text-wrap-pretty
We have already reduced the chance of successive hyphens by only breaking words of at least 12 characters long. Pretty text wrapping still has a performance penalty, so I think
|
Co-authored-by: Aram <37216945+alimpens@users.noreply.github.com>
Describe the pull request
Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.
What
hyphenate-limit-chars
token into the typography group.hyphens
andoverflow-wrap
Why
How
n/a
Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:
Additional notes