Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Header): Change Headings in mega menu examples to level 3 #1912

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

alimpens
Copy link
Contributor

@alimpens alimpens commented Mar 7, 2025

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

Change the Headings in the mega menu examples to h3.

Why

Our Header has a hidden h2 in the navigation section. The following Headings that are part of the navigation section should be h3.

How

n/a

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

@alimpens alimpens requested a review from a team as a code owner March 7, 2025 14:21
@VincentSmedinga VincentSmedinga enabled auto-merge (squash) March 7, 2025 14:26
@github-actions github-actions bot temporarily deployed to demo-fix-heading-hierarchy-in-docs March 7, 2025 14:26 Destroyed
@VincentSmedinga VincentSmedinga merged commit b0b9852 into develop Mar 7, 2025
6 checks passed
@VincentSmedinga VincentSmedinga deleted the fix-heading-hierarchy-in-docs branch March 7, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants