Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Tabs)!: Rename onChange to onTabChange #1908

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

alimpens
Copy link
Contributor

@alimpens alimpens commented Mar 5, 2025

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

This renames the onChange prop to onTabChange.

Why

onChange seemed to conflict with the native React onChange prop.

See also this issue.

How

(How were these changes implemented? Provide a brief overview of the approach taken and any key considerations.)

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

  • Do we also want to change tabId to string now? Or should that be a separate PR?

@alimpens alimpens requested a review from a team as a code owner March 5, 2025 12:03
@alimpens alimpens requested a review from dlnr March 5, 2025 12:06
VincentSmedinga
VincentSmedinga previously approved these changes Mar 5, 2025
Copy link
Contributor

@VincentSmedinga VincentSmedinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want to change tabId to string now? Or should that be a separate PR?

I like small PRs like this, so let’s do that separately. It’s also easier to understand and follow up for our users.

@VincentSmedinga VincentSmedinga dismissed their stale review March 5, 2025 22:16

Reconsidering whether onTabChange isn’t a better name.

Copy link
Contributor

@VincentSmedinga VincentSmedinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait, you did call it onTabChange, just not in the PR title :)

@VincentSmedinga VincentSmedinga changed the title fix(Tabs)!: Rename onChange to onTabsChange fix(Tabs)!: Rename onChange to onTabChange Mar 5, 2025
@VincentSmedinga VincentSmedinga merged commit 2deb358 into develop Mar 5, 2025
7 checks passed
@VincentSmedinga VincentSmedinga deleted the fix/DES-1201-rename-tabs-onchange branch March 5, 2025 22:17
@reno1979
Copy link

reno1979 commented Mar 6, 2025

@alimpens nice one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants