Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Footer): Fix heading hierarchy #1907

Merged
merged 3 commits into from
Mar 7, 2025

Conversation

alimpens
Copy link
Contributor

@alimpens alimpens commented Mar 5, 2025

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

This removes the Heading level 1 from our Footer examples. It also changes a section to a div, a section should not be used for styling purposes only.

Why

According to these docs, there should only be 1 h1 on the page. This means our docs were incorrect.

How

Removed the heading, changed the tag.

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

@alimpens alimpens requested a review from a team as a code owner March 5, 2025 11:00
@alimpens alimpens requested a review from dlnr March 5, 2025 11:00
Copy link
Contributor

@VincentSmedinga VincentSmedinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s consider marking updates to our recommended markup as features instead of chores. If people have implemented this markup before, they should be aware of our changes to it and apply them in their project.

@alimpens
Copy link
Contributor Author

alimpens commented Mar 7, 2025

Let’s consider marking updates to our recommended markup as features instead of chores. If people have implemented this markup before, they should be aware of our changes to it and apply them in their project.

This wouldn't have any effect. This change touches the Storybook package, which we don't release. So it will not be added to any changelog.

@VincentSmedinga VincentSmedinga enabled auto-merge (squash) March 7, 2025 14:12
@github-actions github-actions bot temporarily deployed to demo-fix-footer-heading-hierarchy March 7, 2025 14:12 Destroyed
@VincentSmedinga VincentSmedinga merged commit b55b6fb into develop Mar 7, 2025
6 checks passed
@VincentSmedinga VincentSmedinga deleted the chore/fix-footer-heading-hierarchy branch March 7, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants