Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Card): Prevent other links than the Card Link from stretching #1898

Merged
merged 6 commits into from
Mar 7, 2025

Conversation

VincentSmedinga
Copy link
Contributor

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

It lets only the Card Link stretch to cover the entire Card; not arbitrary other links.

Why

Other links would make the Card difficult to use.

How

  • Replace two instances of the type selector with a class selector
  • Group link styles for clarity and to prevent descending specificity
  • Clarify comments and prevent them from being output in the build

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

  • n/a

@VincentSmedinga VincentSmedinga requested a review from dlnr March 1, 2025 16:24
@VincentSmedinga VincentSmedinga requested a review from a team as a code owner March 1, 2025 16:24
@github-actions github-actions bot temporarily deployed to demo-DES-1209-card-link-selector March 5, 2025 22:26 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1209-card-link-selector March 7, 2025 13:44 Destroyed
@alimpens alimpens enabled auto-merge (squash) March 7, 2025 13:45
@alimpens alimpens merged commit a6d79b0 into develop Mar 7, 2025
6 checks passed
@alimpens alimpens deleted the fix/DES-1209-card-link-selector branch March 7, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants