feat(typography): Improve line heights for all body text and headings #1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentSmedinga
changed the title
VincentSmedinga
changed the title
5 tasks
|
@Bondt007 Please review and, if you agree, approve these changes. Inspect them by clicking ‘Show environments’ in the second to last box, then ‘View deployment’. That will open a Storybook instance with new line heights applied to all text components. Find an overview of the values in Brand > Design Tokens > Typography, or under this PR’s ‘Files Changed’ tab. |
github-actions
bot
temporarily deployed
to
demo-DES-1073-line-height-values
alimpens
approved these changes
Mar 7, 2025
github-actions
bot
temporarily deployed
to
demo-DES-1073-line-height-values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.
What
It updates the line heights for all our text components.
Why
To make text easier to read and to distinguish line heights between body text and headings.
How
n/a
Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:
Additional notes